paths: update get_rare_executable() to handle Flatpak and Snap packaging#693
Closed
loathingKernel wants to merge 1 commit intoRareDevs:mainfrom
Closed
paths: update get_rare_executable() to handle Flatpak and Snap packaging#693loathingKernel wants to merge 1 commit intoRareDevs:mainfrom
get_rare_executable() to handle Flatpak and Snap packaging#693loathingKernel wants to merge 1 commit intoRareDevs:mainfrom
Conversation
…aging In the case of desktop shortcuts or Steam shortcuts we need to invoke the Flatpak or Snap packages in their respective ways since we are not already in the container. For these cases we need `get_rare_executable` to return the command to run Rare externally. There are other cases when we need to invoke one of Rare's sub-applications from inside the container that we don't need to do this, hence the `external` parameter was introduced. Fixes: RareDevs#609 Co-Authored-By: Kyuyrii <kyuyriibyakko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of desktop shortcuts or Steam shortcuts we need to invoke the
Flatpak or Snap packages in their respective ways since we are not already
in the container. For these cases we need
get_rare_executableto returnthe command to run Rare externally.
There are other cases when we need to invoke one of Rare's sub-applications
from inside the container that we don't need to do this, hence the
externalparameter was introduced.
Fixes: RareDevs/Rare#609
Co-Authored-By: Kyuyrii kyuyriibyakko@gmail.com